[Tests] Add missing tests for NWProtocolStack and fix NWParameters tests.#4793
Merged
spouliot merged 2 commits intodotnet:xcode10from Sep 12, 2018
Merged
Conversation
spouliot
suggested changes
Sep 12, 2018
| connectedEvent.Set (); | ||
| void ConnectionStateHandler (NWConnectionState state, NWError error) | ||
| { | ||
| Console.WriteLine ($"State is {state} and error {error}"); |
Contributor
There was a problem hiding this comment.
remove, or comment, debugging output
|
|
||
| void ConnectionStateHandler (NWConnectionState state, NWError error) | ||
| { | ||
| Console.WriteLine ($"State is {state} and error {error}"); |
| host = "www.google.com"; | ||
| using (var parameters = NWParameters.CreateUdp ()) | ||
| using (var endpoint = NWEndpoint.Create (host, "80")) | ||
| { |
Contributor
There was a problem hiding this comment.
minor: { on same line as using
Collaborator
|
Build failure ✅ Build succeeded |
spouliot
approved these changes
Sep 12, 2018
rolfbjarne
approved these changes
Sep 12, 2018
| } | ||
| } | ||
|
|
||
| #endif No newline at end of file |
Member
There was a problem hiding this comment.
Minor: missing EOL for last line.
Collaborator
|
Build success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying the stack of the connection does make the tests for NWParameters to fail, since they'll not wait for the connection to be done. I had to modify the NWParamtersTests to isolate them from the changes done in the stack in other fixtures.